Skip to content

Use Num.bound#1862

Merged
pi8027 merged 1 commit intomath-comp:masterfrom
pi8027:num_bound
Feb 27, 2026
Merged

Use Num.bound#1862
pi8027 merged 1 commit intomath-comp:masterfrom
pi8027:num_bound

Conversation

@pi8027
Copy link
Member

@pi8027 pi8027 commented Feb 26, 2026

Motivation for this change

Given R : archiNumDomainType and x : R, if we need an upper bound of x of type nat, what we need is often Num.bound (math-comp/math-comp#1510 (comment)):

Definition bound (x : R) := (truncn `|x|).+1.
Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@pi8027 pi8027 added the renaming/refactoring 🔧 This is about a renaming or refactoring in the library label Feb 26, 2026
rewrite compact_cover => Aco.
have covA : A `<=` \bigcup_(n : int) [set p | `|p| < n%:~R].
by move=> p _; exists (floor `|p| + 1) => //=; rewrite floorD1_gt.
by move=> p _; exists (truncn `|p|).+1; rewrite //= truncnS_gt.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot use Num.bound here (yet) because p is in a normed module.

@CohenCyril
Copy link
Member

I tried to push a changelog but looks like I'm not allowed

@pi8027
Copy link
Member Author

pi8027 commented Feb 27, 2026

Thanks. I will add a changelog entry and merge.

@CohenCyril
Copy link
Member

Thanks. I will add a changelog entry and merge.

I have one ready, if you just allow me

@pi8027 pi8027 merged commit ba93a11 into math-comp:master Feb 27, 2026
57 of 58 checks passed
@pi8027 pi8027 deleted the num_bound branch February 27, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

renaming/refactoring 🔧 This is about a renaming or refactoring in the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants