Merged
Conversation
pi8027
commented
Feb 27, 2026
| rewrite compact_cover => Aco. | ||
| have covA : A `<=` \bigcup_(n : int) [set p | `|p| < n%:~R]. | ||
| by move=> p _; exists (floor `|p| + 1) => //=; rewrite floorD1_gt. | ||
| by move=> p _; exists (truncn `|p|).+1; rewrite //= truncnS_gt. |
Member
Author
There was a problem hiding this comment.
We cannot use Num.bound here (yet) because p is in a normed module.
CohenCyril
approved these changes
Feb 27, 2026
Member
|
I tried to push a changelog but looks like I'm not allowed |
Member
Author
|
Thanks. I will add a changelog entry and merge. |
Member
I have one ready, if you just allow me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Given
R : archiNumDomainTypeandx : R, if we need an upper bound ofxof typenat, what we need is oftenNum.bound(math-comp/math-comp#1510 (comment)):Definition bound (x : R) := (truncn `|x|).+1.Checklist
CHANGELOG_UNRELEASED.md[ ] added corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers