Skip to content

EVT for rV#1802

Merged
affeldt-aist merged 5 commits intomath-comp:masterfrom
yosakaon:dec20
Feb 28, 2026
Merged

EVT for rV#1802
affeldt-aist merged 5 commits intomath-comp:masterfrom
yosakaon:dec20

Conversation

@yosakaon
Copy link
Contributor

@yosakaon yosakaon commented Dec 20, 2025

Motivation for this change

This is a generalization of the Extreme Value Theorem already present for real-valued functions to R^n.
Should we keep both statements ?

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist
Copy link
Member

We could maybe rename EVT_max/min to EVT_maxR/minR? (and later the generalization compact_EVT_max to EVT_max) @CohenCyril @yosakaon

@affeldt-aist
Copy link
Member

Also, there is this comment left in the code:

(* TODO : Filter not infered *)

What does it mean? Can we remove it? @drouhling

@affeldt-aist
Copy link
Member

Also, there is this comment left in the code:

(* TODO : Filter not infered *)

What does it mean? Can we remove it? @drouhling

Never mind, we concluded with @CohenCyril that this is not relevant anymore.

@affeldt-aist
Copy link
Member

This is a generalization of the Extreme Value Theorem already present for real-valued functions to R^n. Should we keep both statements ?

So @CohenCyril observed a generalization that we have implemented, so this PR actually now generalizes the original statement and provide two variants for the real line and for R^n. It is a strict generalization that we know is useful to others, so to me it is a candidate for merging, let's see that the CI has to say about this.

@affeldt-aist affeldt-aist added this to the 1.16.0 milestone Feb 27, 2026
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Feb 27, 2026
@affeldt-aist
Copy link
Member

CI green. @yosakaon Thanks for PR!

@affeldt-aist affeldt-aist merged commit 7c8cd3f into math-comp:master Feb 28, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants