fix: use current board angle when setting proposal climb as active#868
fix: use current board angle when setting proposal climb as active#868marcodejongh wants to merge 3 commits intomainfrom
Conversation
When a proposal climb was set as the active climb via "Set Active", the climb's angle would be set to 0 or the proposal's stored angle instead of the current board/queue angle. This happened because the climb object from the proposal card carried the proposal's angle. Override the climb's angle with the current board angle in both addToQueue and setCurrentClimb in the GraphQL QueueContext (party mode) and the persistent session queue adapter (local mode). https://claude.ai/code/session_01Na4cZifibvzbqcjysHmDiE
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Claude Review✅ Ready to merge - Minor issues noted below, but nothing blocking. Issues
|
…de tests When the local queue is empty (no current climb), the angle defaults to 0. Previously this would override any added climb's angle to 0. Now only override the climb's angle when there's a real angle source (party session or existing queue item with an angle). Add 4 tests verifying: - addToQueue overrides angle with current queue angle - setCurrentClimb overrides angle with current queue angle - addToQueue preserves climb's original angle on empty queue - setCurrentClimb preserves climb's original angle on empty queue https://claude.ai/code/session_01Na4cZifibvzbqcjysHmDiE
Claude Review✅ Ready to merge - Bug fix is correct and well-tested for the local queue adapter. Minor notes (non-blocking):
No documentation updates needed - this is a bug fix that doesn't affect documented systems. |
The test relied on two sequential saveQueueState calls getting different Date.now() values, but both could execute within the same millisecond, making the result non-deterministic. Write directly to IndexedDB with controlled timestamps instead, matching the pattern used by the corrupted items test. https://claude.ai/code/session_01Na4cZifibvzbqcjysHmDiE
Claude Review✅ Ready to merge - No significant issues found. Bug fix correctly overrides climb angle with current board angle when setting proposal climbs as active. Implementation handles edge cases appropriately (empty queue in local mode preserves original angle). Test coverage is good, including edge cases for both |
2 participants
When a proposal climb was set as the active climb via "Set Active",
the climb's angle would be set to 0 or the proposal's stored angle
instead of the current board/queue angle. This happened because the
climb object from the proposal card carried the proposal's angle.
Override the climb's angle with the current board angle in both
addToQueue and setCurrentClimb in the GraphQL QueueContext (party mode)
and the persistent session queue adapter (local mode).
https://claude.ai/code/session_01Na4cZifibvzbqcjysHmDiE