Skip to content

onchain allocation: DeleteUser deallocate+closeaccount atomically#3113

Merged
elitegreg merged 4 commits intomainfrom
gm/onchain-allocation-issue-2403
Mar 4, 2026
Merged

onchain allocation: DeleteUser deallocate+closeaccount atomically#3113
elitegreg merged 4 commits intomainfrom
gm/onchain-allocation-issue-2403

Conversation

@elitegreg
Copy link
Contributor

Closes #2403

Summary of Changes

  • Modified process_delete_user to handle deallocation and account closure if feature flag is enabled and the user's cli is new enough (passing the extra accounts).
  • Changes the SDK DeleteUser to appropriately call the smartcontract based on feature flag

Testing Verification

  • New tests added
  • Existing tests pass

@elitegreg elitegreg marked this pull request as draft February 26, 2026 16:31
@elitegreg elitegreg force-pushed the gm/onchain-allocation-issue-2403 branch from 7821a65 to 3314d67 Compare March 3, 2026 21:11
Closes #2403

* Modified process_delete_user to handle atomic deallocation and delete
as well if feature flag is enabled and the users cli is new enough
(passing the extra accounts).
* Changes the SDK DeleteUser to appropriately call the smartcontract
based on feature flag

* New tests added
* Existing tests pass
@elitegreg elitegreg force-pushed the gm/onchain-allocation-issue-2403 branch from 3314d67 to 437b0ab Compare March 4, 2026 16:27
@elitegreg elitegreg marked this pull request as ready for review March 4, 2026 16:59
@elitegreg elitegreg enabled auto-merge (squash) March 4, 2026 17:00
@elitegreg elitegreg requested a review from vihu March 4, 2026 17:00
@elitegreg elitegreg merged commit 2900f3b into main Mar 4, 2026
30 checks passed
@elitegreg elitegreg deleted the gm/onchain-allocation-issue-2403 branch March 4, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phase 2: Modify DeleteUser for atomic deallocation

2 participants