Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Contributor
|
I am a bot, here are the test results for this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This adds support for the pause and resume API.
Benefits of this PR and context:
There's one use-case reported so far in the original repository, and I plan to introduce the same change there too.
Essentially, some containers do use the pause/resume functionality, and it's only 2 more lines added, so I don't see why not to add it.
How Has This Been Tested?
I did those changes locally using the following command:
docker build --no-cache --pull -t pause-resume-support-X .Then I pointed my docker compose file to use image: pause-resume-support-X instead.
Finally, I accessed my Portainer instance and hit "Pause" on one of my containers, which worked after this change.
Source / References:
Tecnativa/docker-socket-proxy#171