Open
Conversation
|
I've assigned @benthecarman as a reviewer! |
Expose LSPS2 client settings in so nodes can be configured to source just-in-time liquidity from an LSP. Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <dev@tnull.de>
Expose dedicated LSPS2 invoice endpoints so callers can request fixed and variable-amount JIT invoices without overloading the existing API surface. Generated with the assistance of AI. Co-Authored-By: HAL 9000
Expose the new LSPS2 JIT invoice endpoints through the Rust client and CLI so callers can request either fixed or variable-amount invoices without constructing protobuf messages manually. Generated with the assistance of AI. Co-Authored-By: HAL 9000
tnull
force-pushed
the
2026-03-lsps2-client-support
branch
from
1cfe65e to
80cb7ee
Compare
benthecarman
reviewed
Mar 7, 2026
Collaborator
benthecarman
left a comment
benthecarman
left a comment
There was a problem hiding this comment.
i think your 2nd commit message got screwed up, a couple nits otherwise looks good to me
| # The public key of the LSPS2 LSP we source just-in-time liquidity from. | ||
| node_pubkey = "<lsp node pubkey>" | ||
| # Address to connect to the LSPS2 LSP (IPv4:port, IPv6:port, OnionV3:port, or hostname:port). | ||
| address = "127.0.0.1:9735" |
Collaborator
There was a problem hiding this comment.
can we make this not a local host ip, that might confused people thinking its something they are supposed to run
| Bolt11ReceiveViaJitChannel { | ||
| #[arg(help = "Amount to request, e.g. 50sat or 50000msat")] | ||
| amount: Amount, | ||
| #[arg(short, long, help = "Description to attach along with the invoice")] |
Collaborator
There was a problem hiding this comment.
can we drop short, long here so you can just feed the description directly
| )] | ||
| Bolt11ReceiveVariableAmountViaJitChannel { | ||
| #[arg(short, long, help = "Description to attach along with the invoice")] | ||
| description: Option<String>, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to connect my server to an LSP but found that it currently doesn't expose the corresponding APIs. Here we add them.