Open
Conversation
Signed-off-by: Hitarth Hindocha <hindochahitarth@gmail.com>
Signed-off-by: Hitarth Hindocha <hindochahitarth@gmail.com>
Signed-off-by: Hitarth Hindocha <hindochahitarth@gmail.com>
Signed-off-by: Hitarth Hindocha <hindochahitarth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
GDG CHARUSAT TEAM ID Team 137
Description
Description
This PR introduces a
bookCount
virtual field to the
Author
type. Previously, to find out how many books an author had written, clients had to fetch the entire list of books and count them manually. This enhancement provides a direct, efficient way to retrieve the total count.
Summary of changes:
GraphQL Schema: Added bookCount: Int to the
Author
type definition.
BookController
: Implemented a @schemamapping method
bookCount(Author author)
that calculates the size of the author's book collection.
Performance: This allows clients to query for high-level statistics without the overhead of downloading full book details.
Closes keploy/keploy#3890
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The changes were verified manually using curl against the local GraphQL endpoint.
Test Case: Fetching Author Statistics
Setup: Ensure an author exists with multiple books assigned.
Execution: Run the following curl command:
bash
curl -X POST http://localhost:8081/graphql
-H "Content-Type: application/json"
-d '{"query": "{ getAllAuthors { firstName lastName bookCount } }"}'
Expected Result: The API returns the authors with a
bookCount
integer representing the number of books they are associated with.
Additional Context (Please include any Screenshots/gifs if relevant)
This is a non-breaking enhancement that improves data efficiency for UI components like author lists or profile summaries where only the count is required.
...
Checklist:
GDG CHARUSAT TEAM ID Team 137