Skip to content

feat: added support for error.cause across instrumentations #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aryamohanan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: added support for error.cause across instrumentations #2383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32acee6
feat: added support for error.cause across all instrumentations
aryamohanan Mar 2, 2026
0db9881
chore: updated
aryamohanan Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/src/tracing/instrumentation/cloud/aws-sdk/v2/instana_aws_product.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

'use strict';

const tracingUtil = require('../../../../tracingUtil');

class InstanaAWSProduct {
/**
* @param {string} spanName
Expand Down Expand Up @@ -50,7 +52,7 @@ class InstanaAWSProduct {
span.ec = 1;
const spanData = span.data && span.data[this.spanName];
if (spanData) {
spanData.error = err.message || err.code || JSON.stringify(err);
spanData.error = tracingUtil.extractErrorMessage(err);
}
}
}
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/tracing/instrumentation/cloud/aws-sdk/v3/instana_aws_product.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

'use strict';

const tracingUtil = require('../../../../tracingUtil');

class InstanaAWSProduct {
/**
* @param {string} spanName
Expand Down Expand Up @@ -49,7 +51,7 @@ class InstanaAWSProduct {
if (err) {
span.ec = 1;
if (span.data?.[this.spanName]) {
span.data[this.spanName].error = err.message || err.code || JSON.stringify(err);
span.data[this.spanName].error = tracingUtil.extractErrorMessage(err);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/tracing/instrumentation/databases/memcached.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ function addErrorToSpan(err, span) {
if (err) {
span.ec = 1;
if (span.data?.[SPAN_NAME]) {
span.data[SPAN_NAME].error = err.message || err.code || JSON.stringify(err);
span.data[SPAN_NAME].error = tracingUtil.extractErrorMessage(err);
}
}
}
17 changes: 6 additions & 11 deletions packages/core/src/tracing/instrumentation/databases/redis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,18 +508,13 @@ function instrumentMultiExec(origCtx, origArgs, original, address, isAtomic, cbS
if (err) {
span.ec = 1;

if (err.message) {
span.data.redis.error = err.message;
} else if (Array.isArray(err) && err.length) {
span.data.redis.error = err[0].message;
if (Array.isArray(err) && err.length) {
span.data.redis.error = tracingUtil.extractErrorMessage(err[0]);
} else if (err.errors && err.errors.length) {
// v3 = provides sub errors
span.data.redis.error = err.errors.map(subErr => tracingUtil.extractErrorMessage(subErr)).join('\n');
} else {
span.data.redis.error = 'Unknown error';
}

// v3 = provides sub errors
if (err.errors && err.errors.length) {
// TODO: Not updating now as special case
span.data.redis.error = err.errors.map(subErr => subErr.message).join('\n');
span.data.redis.error = tracingUtil.extractErrorMessage(err);
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/tracing/instrumentation/frameworks/express.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function shimExpressHandle(realHandle) {

function wrapExpress4HandleFn(fn) {
return function wrappedHandleFn(err) {
if (err && err.message && err.stack) {
if (err && (err.message || err.cause) && err.stack) {
annotateHttpEntrySpanWithError(err);
}
return fn.apply(this, arguments);
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/tracing/instrumentation/protocols/graphql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ function finishSpan(span, result) {
function finishWithException(span, err) {
span.ec = 1;
span.d = Date.now() - span.ts;
span.data.graphql.errors = err.message;
span.data.graphql.errors = tracingUtil.extractErrorMessage(err);
if (!span.postponeTransmit) {
span.transmit();
}
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/tracing/instrumentation/protocols/grpcJs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ function modifyArgs(name, originalArgs, span) {
span.d = Date.now() - span.ts;

if (err) {
const errorMessage = err.details || err.message;
const errorMessage = tracingUtil.extractErrorMessage(err);
if (typeof errorMessage === 'string' && errorMessage.toLowerCase().includes('cancelled')) {
// No-op, we do not want to mark cancelled calls as erroneous.
} else {
Expand Down Expand Up @@ -420,7 +420,7 @@ function instrumentedClientMethod(

call.on('error', err => {
span.d = Date.now() - span.ts;
const errorMessage = err.details || err.message;
const errorMessage = tracingUtil.extractErrorMessage(err);
if (typeof errorMessage === 'string' && errorMessage.toLowerCase().includes('cancelled')) {
// No-op, we do not want to mark cancelled calls as erroneous.
} else {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/tracing/instrumentation/protocols/httpClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ function instrument(coreModule, forceHttps) {
});

clientRequest.on('error', err => {
let errorMessage = err.message || err.code;
let errorMessage = tracingUtil.extractErrorMessage(err);

if (isTimeout) {
errorMessage = 'Timeout exceeded';
Expand Down