Skip to content

chore: replaced kafka test images#2372

Merged
abhilash-sivan merged 6 commits intomainfrom
chore-replace-kafka-images
Mar 2, 2026
Merged

chore: replaced kafka test images#2372
abhilash-sivan merged 6 commits intomainfrom
chore-replace-kafka-images

Conversation

@abhilash-sivan
Copy link
Contributor

@abhilash-sivan abhilash-sivan commented Feb 24, 2026

@abhilash-sivan abhilash-sivan changed the title chore: replaced kafka image chore: replaced kafka images with internal icr registry Feb 24, 2026

zookeeper:
image: confluentinc/cp-zookeeper:7.9.0
image: confluentinc/cp-zookeeper:7.9.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned the image versions used in the sidecar for local development.

Since this Docker Compose setup is intended for developers and the project is open source, I have not changed the image reference in the Docker Compose file. Keeping the public image avoids forcing open-source contributors (who don’t have access to our internal registry) to manually locate and replace the image for their local usage.

I strongly believe this is the correct approach. The only required change was in the sidecars, and that has been completed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki.

Did you try these btw?

public.ecr.aws/aktosecurity/confluentinc-cp-kafka:7.9.1-1-ubi8
public.ecr.aws/aktosecurity/confluentinc-cp-zookeeper:7.9.2-1-ubi8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, haven't tried. any other non-official images
Can we use this in sidecars as well ? or just for dev use

@abhilash-sivan abhilash-sivan marked this pull request as ready for review February 24, 2026 14:55
@abhilash-sivan abhilash-sivan requested a review from a team as a code owner February 24, 2026 14:55
Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Kafka image update also requires updating the image references in the Tekton tasks too

@abhilash-sivan
Copy link
Contributor Author

The Kafka image update also requires updating the image references in the Tekton tasks too

Yes, updated now! Let the pipeline run

@abhilash-sivan abhilash-sivan force-pushed the chore-replace-kafka-images branch from 253a2ef to a716de4 Compare February 25, 2026 07:01
@abhilash-sivan abhilash-sivan changed the title chore: replaced kafka images with internal icr registry chore: replaced kafka images Mar 2, 2026
}
},
{
"name": "schema-registry",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Schema Registry as it does not appear to be required for running the tests.

kafka-topics:
image: confluentinc/cp-kafka:7.9.0
image: public.ecr.aws/aktosecurity/confluentinc-cp-kafka:7.9.1-1-ubi8
pull_policy: if_not_present
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added pull policy for all test images

@abhilash-sivan abhilash-sivan force-pushed the chore-replace-kafka-images branch from 865c285 to d354ba8 Compare March 2, 2026 07:36
Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments. Preapproving

SCHEMA_REGISTRY_KAFKASTORE_CONNECTION_URL: 'zookeeper:2181'
SCHEMA_REGISTRY_KAFKASTORE_BOOTSTRAP_SERVERS: "PLAINTEXT://kafka:29092"
SCHEMA_REGISTRY_DEBUG: 'true'
# schema-registry:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qs: Could we remove it completely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes done

sidecars:
- name: zookeeper
image: confluentinc/cp-zookeeper:7.9.1
image: public.ecr.aws/aktosecurity/confluentinc-cp-zookeeper:7.9.2-1-ubi8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qs: Could we use the same image version every where? like 7.9.2-1-ubi8? and why we can't use the latest (v8)image version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are compatibility concerns with the latest v8 image since it is aligned with Apache Kafka v4.

However, our current dependencies use older client versions (ranging from 0.9 to 2.12). While some of them are compatible with Kafka v3, upgrading directly to Kafka v4 may introduce unexpected issues.

Additionally, during local testing, I noticed an issue with the v8 image. I haven’t investigated it in detail yet, but it adds some uncertainty.

For now, we can proceed with the latest available minor version in the 7.9 line:

public.ecr.aws/aktosecurity/confluentinc-cp-kafka:7.9.4-1-ubi8

This corresponds to Confluent Platform 7.9.x, which is stable and aligned with Kafka 3.x.

We can plan to move to the v8 (Kafka 4.x–based) image later if required, once compatibility and testing are validated.

@abhilash-sivan abhilash-sivan force-pushed the chore-replace-kafka-images branch from 7f1654c to e621eeb Compare March 2, 2026 12:09
@abhilash-sivan abhilash-sivan changed the title chore: replaced kafka images chore: replaced kafka test images Mar 2, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@abhilash-sivan abhilash-sivan merged commit 5c247fe into main Mar 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants