Skip to content

Don't fall back to Apollo when not in subprotocols #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaylett wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't fall back to Apollo when not in subprotocols #586

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9204d32
Don't fall back to Apollo when not in subprotocols
jaylett Feb 24, 2026
a132000
fixup! Don't fall back to Apollo when not in subprotocols
jaylett Feb 24, 2026
ed18026
fixup! fixup! Don't fall back to Apollo when not in subprotocols
jaylett Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions gql/transport/websockets_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,12 +479,18 @@ async def _after_connect(self):
# Find the backend subprotocol returned in the response headers
try:
self.subprotocol = self.response_headers["Sec-WebSocket-Protocol"]
log.debug(f"backend subprotocol returned: {self.subprotocol!r}")
except KeyError:
# If the server does not send the subprotocol header, using
# the apollo subprotocol by default
self.subprotocol = self.APOLLO_SUBPROTOCOL

log.debug(f"backend subprotocol returned: {self.subprotocol!r}")
# If the server does not send the subprotocol header, use
# the apollo subprotocol by default unless we didn't ask for it
if (
self.adapter.subprotocols is None
or self.APOLLO_SUBPROTOCOL in self.adapter.subprotocols
):
self.subprotocol = self.APOLLO_SUBPROTOCOL
else:
self.subprotocol = self.GRAPHQLWS_SUBPROTOCOL
log.debug(f"backend returned no subprotocol, using: {self.subprotocol!r}")

async def _after_initialize(self):

Expand Down
Loading