Conversation
Adds a new system test, test_basic_wrd_x_region, to verify functionality with cross-region GCS buckets. Also updates the Cloud Build configuration to pass the necessary _CROSS_REGION_BUCKET environment variable to the test environment.
Renames open_retries to _open_retries in AsyncMultiRangeDownloader to encapsulate the retry counter. Updates test_zonal.py to verify the private attribute.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new system test to validate the behavior of asynchronous multi-range downloads and appends with Google Cloud Storage buckets configured for cross-region access. It ensures that the system can correctly handle data operations across different geographical regions, and updates the build process to support this new testing scenario. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a system test for cross-region buckets, which is a valuable addition. My review focuses on improving the consistency of environment variable naming for better maintainability. I've suggested changes in both the Cloud Build configuration and the test file to align the new variable with existing conventions.
feat: Add system test for cross-region buckets
Adds a new system test, test_basic_wrd_x_region, to verify functionality with cross-region GCS buckets.
Also updates the Cloud Build configuration to pass the necessary _CROSS_REGION_BUCKET environment variable to the test environment
This PR is a cherry-picked from #1760 because that PR is blocked by b/489420625