fix: Job result returns proper page when start_index and page_size are not null

[manucalop]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes googleapis/google-cloud-python#15724 🦕

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[manucalop]

CLA is fixed now

[manucalop]

Hi! Any updates on this? Could someone rerun the CLA job? I've already updated my status

[chalmerlowe]

Thanks for submitting a PR.

I took a quick look.

• Gonna run our CI/CD checks on this.
• My first thought is that because we are adding a couple code paths coverage is likely to fail.

[manucalop]

Hi! Any update on this? Anything I can do to help?

[chalmerlowe]

@manucalop

I will do my best to take a look at this PR today. I appreciate your time and effort to help out the project.

[chalmerlowe]

I got derailed yesterday. I am looking at a number of issues related to page_size handling by the bigquery library, so this is on my radar, I just didn't have a change to look closely.

I do see that coverage was not happy with this change so we will potentially need to consider the addition of a test or two to ensure that we fully exercise all the code paths around and through this code change.

Name                                Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------
google/cloud/bigquery/job/query.py    801      1    170      1    99%   1551

[chalmerlowe]

Migration Notice: This library is moving to the google-cloud-python monorepo soon.

We closed this PR due to inactivity to ensure a clean migration. Please re-open this work in the new monorepo once the migration is complete!