Skip to content

Update logic to identify Swarming task#5173

Merged
jardondiego merged 3 commits intomasterfrom
fix-identify-swarming-task
Mar 2, 2026
Merged

Update logic to identify Swarming task#5173
jardondiego merged 3 commits intomasterfrom
fix-identify-swarming-task

Conversation

@jardondiego
Copy link
Collaborator

@jardondiego jardondiego commented Feb 26, 2026

In order to actually identify Swarming tasks, we will look at the job configuration for a flag IS_SWARMING_TASK.

@jardondiego jardondiego marked this pull request as ready for review February 26, 2026 17:56
Copy link
Collaborator

@javanlacerda javanlacerda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: This is the logic that runs inside the swarming machine it self right? Not the logic that schedules a swarming job.

@jardondiego
Copy link
Collaborator Author

Question: This is the logic that runs inside the swarming machine it self right? Not the logic that schedules a swarming job.

Yes, but it is also used in several places, when dispatching the task to Swarming it first checks for that condition, as well as used to identify it as a remote task in src/clusterfuzz/_internal/bot/tasks/task_types.py.

Copy link
Collaborator

@letitz letitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@letitz
Copy link
Collaborator

letitz commented Feb 27, 2026

Question: This is the logic that runs inside the swarming machine it self right? Not the logic that schedules a swarming job.

Yes, but it is also used in several places, when dispatching the task to Swarming it first checks for that condition, as well as used to identify it as a remote task in src/clusterfuzz/_internal/bot/tasks/task_types.py.

I think the answer to @javanlacerda's question is largely no. This is mostly used to determine where to schedule utask_main 1. It's somewhat anecdotally used during the execution of tasks, e.g. to annotate metrics with an execution_mode label 2.

@jardondiego jardondiego merged commit 5dc346a into master Mar 2, 2026
9 of 11 checks passed
@jardondiego jardondiego deleted the fix-identify-swarming-task branch March 2, 2026 15:59
jardondiego added a commit that referenced this pull request Mar 2, 2026
jardondiego added a commit that referenced this pull request Mar 2, 2026
This reverts commit 5dc346a. 
Due to recent conflicting changes in that module, these changes need to
be reconsidered.
Will revert for now until a new PR with the right changes is created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants