Skip to content

Reimplement integration-e2e workflow #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hung-nguyen-hoang merged 1 commit into from
Mar 6, 2026
Merged

Reimplement integration-e2e workflow #2073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions .github/workflows/check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,25 @@ jobs:
id: changed-files
uses: tj-actions/changed-files@v45

gooddata-ruby-lcm-integration-e2e:
needs:
- prepare-env
uses: ./.github/workflows/lcm-integration-e2e.yaml
secrets: inherit
permissions:
id-token: write
contents: read
if: ${{ needs.prepare-env.outputs.branch == 'master' }}
with:
AUTO_MERGE: false
base_branch: ${{ needs.prepare-env.outputs.branch }}
pr_number: ${{ needs.prepare-env.outputs.pr_number }}
java_version: '11'
ruby_version: 'jruby-9.4.12.1'

gooddata-ruby-lcm-build-pipeline:
#needs:
# - gooddata-ruby-lcm-integration-e2e
needs:
- gooddata-ruby-lcm-integration-e2e
permissions:
contents: read
id-token: write
Expand Down Expand Up @@ -97,7 +113,7 @@ jobs:
needs:
- prepare-env
- gooddata-ruby-lcm-build-pipeline
# - gooddata-ruby-fossa-licenses-validate-LR-ticket-zuul
- gooddata-ruby-fossa-licenses-validate-LR-ticket-zuul
steps:
- name: Check if needed jobs succeeded
uses: re-actors/alls-green@release/v1
Expand Down
2 changes: 0 additions & 2 deletions lib/gooddata/rest/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ class Connection
TOKEN_PATH = '/gdc/account/token'
KEYS_TO_SCRUB = [:password, :verifyPassword, :authorizationToken]
API_LEVEL = 2
KB = 1024
MB = 1024 * KB

ID_LENGTH = 16

Expand Down
6 changes: 6 additions & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@

GoodData::Environment.load

if RUBY_ENGINE == "jruby" && RUBY_ENGINE_VERSION >= '9.4.12.0'
KB = 1024
MB = 1024 * KB
Psych::Parser.code_point_limit = 100 * MB
end

Copy link
Contributor

@hung-nguyen-hoang hung-nguyen-hoang Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove not used coded at https://github.com/gooddata/gooddata-ruby/blob/master/lib/gooddata/rest/connection.rb#L36-L37

Copy link
Contributor Author

@santos1709 santos1709 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

RSpec::Expectations.configuration.warn_about_potential_false_positives = false

RSpec.configure do |config|
Expand Down
Loading