fix: Inconsistent Variable Expansion When Using {{.VAR}} in .env Files with Nested Variables#2612
Open
majiayu000 wants to merge 1 commit intogo-task:mainfrom
Conversation
Fixed non-deterministic iteration order when processing dotenv files by
introducing ReadDotenvOrdered which reads key-value pairs in the order
they appear in the file. This prevents race conditions when variables
reference each other with template syntax like {{.VAR}}.
The issue occurred because godotenv.Read() returns a map[string]string,
and Go map iteration order is non-deterministic. This caused inconsistent
variable expansion when nested variables depended on the order of
processing.
Signed-off-by: majiayu000 <1835304752@qq.com>
|
(ignore my previous comment, i was on the main branch...) A task to run the cmds: work consistently and as expected now. |
trulede
reviewed
Mar 2, 2026
| } | ||
|
|
||
| envs, err := godotenv.Read(dotEnvPath) | ||
| envs, err := ReadDotenvOrdered(dotEnvPath) |
Contributor
There was a problem hiding this comment.
Would it be possible to parse directly into the ast.Vars object. Something like this:
err := ReadFromDotenv(env, dotEnvPath)
That would simply things significantly (all the key/slice handling).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #1847
Changes
taskfile/dotenv.gotaskfile/dotenv_test.govariables.go