fix: moves COPILOT_HOOKS_DENY_DEMO guard to ensure deny() in scope#43103
Open
ohainle wants to merge 1 commit intogithub:mainfrom
Open
fix: moves COPILOT_HOOKS_DENY_DEMO guard to ensure deny() in scope#43103ohainle wants to merge 1 commit intogithub:mainfrom
ohainle wants to merge 1 commit intogithub:mainfrom
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Closes: #43102
What's being changed (if available, include any code snippets, screenshots, or gifs):
This PR addresses the script failures discussed in #43102, amending the
pre-tool-policy.shbash example script listed at https://docs.github.com/en/copilot/tutorials/copilot-cli-hooks#example-script-bash.By moving the
COPILOT_HOOKS_DENY_DEMOguard to below thedeny()declaration, we ensure thatdeny()is always in scope when invoked.Note
This PR only addresses the bash examples, as I don't currently have access to a PowerShell environment to reproduce and confirm the issue on that end.
I'm happy for this PR to be hijacked and updated with PowerShell fixes, if convenient.
Otherwise, the issue should remain open until PowerShell examples have been investigated, and if necessary amended.
Check off the following: