Skip to content

Comments

Revert SoftFloat changes#1055

Merged
jketema merged 1 commit intogithub:nextfrom
jketema:jketema/softfloat-revert
Feb 24, 2026
Merged

Revert SoftFloat changes#1055
jketema merged 1 commit intogithub:nextfrom
jketema:jketema/softfloat-revert

Conversation

@jketema
Copy link
Collaborator

@jketema jketema commented Feb 24, 2026

Description

please enter the description of your change here

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

  • Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Reviewer

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Copilot AI review requested due to automatic review settings February 24, 2026 10:18
@jketema jketema changed the base branch from main to next February 24, 2026 10:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts changes to test expectation files that were previously modified as part of "SoftFloat changes". The revert restores the original floating-point literal representations in test expectations and re-enables several test cases that were previously not being reported.

Changes:

  • Restore test expectation for floating-point conversion in M5-0-6, changing from scientific notation to full precision representation
  • Re-enable and restore two test cases in M2-13-4 for literal suffix detection on floating-point literals
  • Re-enable and restore five test cases in A13-6-1 for digit sequence separator validation on floating-point literals

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
cpp/autosar/test/rules/M5-0-6/ImplicitConstConversionToSmallerUnderlyingType.expected Restores line 2 test expectation with full precision floating-point representation (3.500000000000000016e+38 instead of 3.5E38)
cpp/autosar/test/rules/M2-13-4/LiteralSuffixNotUpperCase.expected Re-enables lines 11-12 test expectations for floating-point literals with different representations (1.123122995e+10 and 11231230000.0 instead of 1.123123E10)
cpp/autosar/test/rules/A13-6-1/UseCorrectIntervalForDigitSequencesSeparators.expected Re-enables lines 10-14 test expectations for floating-point literals with decimal representation (11000000000.0 instead of 1.1E10)
Comments suppressed due to low confidence (1)

cpp/autosar/test/rules/M5-0-6/ImplicitConstConversionToSmallerUnderlyingType.expected:1

  • The PR template checklist is incomplete. Consider marking: (1) "Query files" under "Change request type" since test expectation files are being modified, (2) whether a change note is required - since test expectations are changing, this suggests query results may change and a change note may be needed per the development handbook guidelines that state a change note is required when modifying "The results of an existing query in any circumstance".
| test.cpp:11:8:11:10 | (int8_t)... | Implicit conversion of integral $@ reduces the size from 4 bytes to 1 bytes. | test.cpp:11:8:11:10 | 256 | 256 |

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,2 +1,2 @@
| test.cpp:11:8:11:10 | (int8_t)... | Implicit conversion of integral $@ reduces the size from 4 bytes to 1 bytes. | test.cpp:11:8:11:10 | 256 | 256 |
| test.cpp:24:9:24:14 | (float)... | Implicit conversion of floating point $@ reduces the size from 8 bytes to 4 bytes. | test.cpp:24:9:24:14 | 3.5E38 | 3.5e38 |
| test.cpp:24:9:24:14 | (float)... | Implicit conversion of floating point $@ reduces the size from 8 bytes to 4 bytes. | test.cpp:24:9:24:14 | 3.500000000000000016e+38 | 3.5e38 |
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is incomplete and doesn't explain what "SoftFloat changes" are being reverted or why this revert is necessary. Consider adding a description explaining: (1) what the original SoftFloat changes were, (2) why they are being reverted, and (3) whether this revert is fixing a bug or restoring expected behavior.

This issue also appears on line 1 of the same file.

Copilot uses AI. Check for mistakes.
@jketema jketema merged commit 330fc79 into github:next Feb 24, 2026
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant