Skip to content

Comments

[GHSA-3ppc-4f35-3m26] minimatch has a ReDoS via repeated wildcards with non-matching literal in pattern#7018

Closed
robinbisping wants to merge 1 commit intorobinbisping/advisory-improvement-7018from
robinbisping-GHSA-3ppc-4f35-3m26
Closed

[GHSA-3ppc-4f35-3m26] minimatch has a ReDoS via repeated wildcards with non-matching literal in pattern#7018
robinbisping wants to merge 1 commit intorobinbisping/advisory-improvement-7018from
robinbisping-GHSA-3ppc-4f35-3m26

Conversation

@robinbisping
Copy link

Updates

  • Affected products

Comments
The developer has also backported the fix to previous major versions. See: GHSA-3ppc-4f35-3m26

@github
Copy link
Collaborator

github commented Feb 23, 2026

Hi there @isaacs! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Copilot AI review requested due to automatic review settings February 23, 2026 13:06
@github-actions github-actions bot changed the base branch from main to robinbisping/advisory-improvement-7018 February 23, 2026 13:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub-reviewed advisory for GHSA-3ppc-4f35-3m26 (minimatch ReDoS) to reflect additional affected product ranges after the fix was backported to multiple prior major versions.

Changes:

  • Updated the advisory modified timestamp.
  • Added additional affected entries for minimatch to include backported fixed versions across multiple major lines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +36 to +52
},
{
"package": {
"ecosystem": "npm",
"name": "minimatch"
},
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0"
},
{
"fixed": "9.0.6"
}
]
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All newly added affected entries use {"introduced": "0"} with different fixed versions. With semver ordering, the first range introduced: 0fixed: 10.2.1 still marks versions like 9.0.6, 8.0.5, etc. as affected (since they’re < 10.2.1), so the backported fix releases will be incorrectly reported as vulnerable. Model backports as disjoint ranges by setting introduced to the start of each maintained major line (eg 10.0.010.2.1, 9.0.09.0.6, …) and keep only the oldest range as 03.1.3 (or whichever earliest fixed version applies).

Copilot uses AI. Check for mistakes.
@github-actions github-actions bot deleted the robinbisping-GHSA-3ppc-4f35-3m26 branch February 23, 2026 13:32
@robinbisping
Copy link
Author

robinbisping commented Feb 23, 2026

Replaced by: #7021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants