Skip to content

Comments

[GHSA-3ppc-4f35-3m26] minimatch has a ReDoS via repeated wildcards with non-matching literal in pattern#7012

Closed
timbru31 wants to merge 1 commit intotimbru31/advisory-improvement-7012from
timbru31-GHSA-3ppc-4f35-3m26
Closed

[GHSA-3ppc-4f35-3m26] minimatch has a ReDoS via repeated wildcards with non-matching literal in pattern#7012
timbru31 wants to merge 1 commit intotimbru31/advisory-improvement-7012from
timbru31-GHSA-3ppc-4f35-3m26

Conversation

@timbru31
Copy link

Updates

  • Affected products
  • References

Comments
Adding version information for the backported fixes from v3 to v9 (isaacs/minimatch#275 (comment))

Copilot AI review requested due to automatic review settings February 23, 2026 07:24
@github
Copy link
Collaborator

github commented Feb 23, 2026

Hi there @isaacs! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions github-actions bot changed the base branch from main to timbru31/advisory-improvement-7012 February 23, 2026 07:25
@timbru31
Copy link
Author

There is no way of seeing the list of open improvements for an advisory and the UI does not take one straight to the PR overview. Let's keep #7002

@timbru31 timbru31 closed this Feb 23, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GHSA advisory record for minimatch (GHSA-3ppc-4f35-3m26) to reflect additional backported fix versions and adds a supporting reference link.

Changes:

  • Expanded the affected section with additional npm minimatch fixed versions (intended to capture backports across major lines).
  • Added a reference to the upstream minimatch issue comment that documents the backported fixes.
  • Bumped the advisory modified timestamp.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +36 to +52
},
{
"package": {
"ecosystem": "npm",
"name": "minimatch"
},
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0"
},
{
"fixed": "9.0.6"
}
]
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added affected entries all use {"introduced": "0"} with different fixed versions. In OSV semantics these ranges are unioned, which will incorrectly mark versions that are actually fixed via backports (e.g., 9.0.6, 8.0.5, etc.) as still vulnerable because they are < 10.2.1. To represent backported fixes across major release lines, each entry should start at the relevant major (or branch) introduction point (e.g., introduced: 10.0.0 -> fixed: 10.2.1, introduced: 9.0.0 -> fixed: 9.0.6, …, and likely introduced: 0 -> fixed: 3.1.3 for v0–v3).

Copilot uses AI. Check for mistakes.
@github-actions github-actions bot deleted the timbru31-GHSA-3ppc-4f35-3m26 branch February 23, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants