fix: path-based routing broken due to key collisions in sanitize()#2524
Open
shreyaspapi wants to merge 3 commits intofosrl:mainfrom
Open
fix: path-based routing broken due to key collisions in sanitize()#2524shreyaspapi wants to merge 3 commits intofosrl:mainfrom
shreyaspapi wants to merge 3 commits intofosrl:mainfrom
Conversation
…isions Use encodePath only for internal map key grouping (collision-free) and sanitize for Traefik-facing router/service names (unchanged for existing users). Extract pure functions into pathUtils.ts so tests can run without DB dependencies.
shreyaspapi
force-pushed
the
fix/2294-path-based-routing
branch
from
d916cf4 to
8b90107
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Fixes #2294
What this fixes
The
sanitize()function used to generate internal map keys for grouping targets ingetTraefikConfigcan cause path collisions. It replaces all non-alphanumeric characters (including/,.,_) with dashes and collapses them, so structurally different paths can produce the same key:sanitize("/a/b")="a-b"sanitize("/a-b")="a-b"(same!)When two targets get the same key, they're grouped into one loadbalancer service and Traefik round-robins between them instead of routing by path.
Note: this specific collision doesn't affect the
/vs/apiscenario reported in the issue (those already produce different keys), but it would affect setups with paths like/api/v1vs/api-v1or/app.v2vs/app/v2.How to test?
/api/v1and/api-v1)