fix: clean up ACME certs when resources are deleted#2523
Open
shreyaspapi wants to merge 2 commits intofosrl:mainfrom
Open
fix: clean up ACME certs when resources are deleted#2523shreyaspapi wants to merge 2 commits intofosrl:mainfrom
shreyaspapi wants to merge 2 commits intofosrl:mainfrom
Conversation
ba7c3d3 to
9f31532
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Fixes #2382
What's wrong
When you delete a resource, Traefik keeps its certificate in
acme.jsonand keeps renewing it forever. ThedeleteResourcehandler only removes the DB row — it never touches the ACME storage.What this does
acme.jsonso Traefik stops renewing itacme_json_pathoption (defaults to/app/config/letsencrypt/acme.json)How to test?
acme.json