This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP-stable][web] Ensure Flutter adds a generator meta-tag.#57279
Closed
flutteractionsbot wants to merge 1 commit intoflutter:flutter-3.27-candidate.0from
Closed
Conversation
Adds a `meta name="generator" content="Flutter"` tag when the engine UI initializes. ## Issues Fixes flutter/flutter#156262 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
flutteractionsbot
added
the
cp: review
Author
|
@ditman please fill out the PR description above, afterwards the release team will review this request. |
Member
|
Done! |
mdebbar
approved these changes
Jan 30, 2025
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
LGTM, but I think we need a review from the release team.
Member
|
|
yjbanov
approved these changes
Jan 31, 2025
Contributor
|
This ended up getting into the 3.29 stable without a cherrypick. So I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
flutter/flutter#156262
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Adds a meta generator tag to Flutter web apps, for attribution.
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
This is needed for AdSense attribution.
Workaround:
Is there a workaround for this issue?
Users may be able to add the meta-tag manually, but they have no incentive to do so.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Deploy a Flutter web app, and check that the
metatag gets added to the DOM of the page when it starts.