Skip to content

[video_player_avplay] Upgrade plusplayer#965

Open
gin7773 wants to merge 1 commit intoflutter-tizen:masterfrom
gin7773:upgrade-plusplayer-0303
Open

[video_player_avplay] Upgrade plusplayer#965
gin7773 wants to merge 1 commit intoflutter-tizen:masterfrom
gin7773:upgrade-plusplayer-0303

Conversation

@gin7773
Copy link
Contributor

@gin7773 gin7773 commented Mar 3, 2026

Main changes:

  • Update plusplayer
    1. [HLS] Fix for sigsegv when external track in content.
    2. [HLS] Fix for Memory increase after discontinuity due to wrong content format received for cmaf content.
    3. [HLS] MA Handling for Invalid Cmaf Segment.
    4. [HLS] Added log for checking ad drift, printing manifest start time and json start time of the ad.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the video_player_avplay package to version 0.8.4. This involves updating the version number in pubspec.yaml and README.md, and adding a corresponding entry to CHANGELOG.md. My feedback focuses on improving the clarity of the new changelog entry to make it more user-friendly.

Comment on lines +3 to +7
* Update plusplayer
1. [HLS] Fix for sigsegv when external track in content.
2. [HLS] Fix for Memory increase after discontinuity due to wrong content format received for cmaf content.
3. [HLS] MA Handling for Invalid Cmaf Segment.
4. [HLS] Added log for checking ad drift, printing manifest start time and json start time of the ad.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve readability for package consumers, consider rephrasing the changelog entry to be more descriptive and less technical. The current notes appear to be internal development notes. Per the repository style guide, documentation should be useful. Making these notes more user-friendly would increase the quality of the documentation.

Suggested change
* Update plusplayer
1. [HLS] Fix for sigsegv when external track in content.
2. [HLS] Fix for Memory increase after discontinuity due to wrong content format received for cmaf content.
3. [HLS] MA Handling for Invalid Cmaf Segment.
4. [HLS] Added log for checking ad drift, printing manifest start time and json start time of the ad.
* Updates `plusplayer` to include the following HLS-related improvements:
* Fixed a crash (`SIGSEGV`) when using content with external tracks.
* Fixed a memory leak that occurred after a discontinuity with CMAF content.
* Improved handling of invalid CMAF segments.
* Added logs for debugging ad drift, including manifest and ad JSON start times.
References
  1. The style guide states that documentation should be useful. The suggested change improves the usefulness of the changelog by making it more readable and understandable for end-users. (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant