[video_player_avplay] Upgrade plusplayer#965
Open
gin7773 wants to merge 1 commit intoflutter-tizen:masterfrom
Open
[video_player_avplay] Upgrade plusplayer#965gin7773 wants to merge 1 commit intoflutter-tizen:masterfrom
gin7773 wants to merge 1 commit intoflutter-tizen:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades the video_player_avplay package to version 0.8.4. This involves updating the version number in pubspec.yaml and README.md, and adding a corresponding entry to CHANGELOG.md. My feedback focuses on improving the clarity of the new changelog entry to make it more user-friendly.
Comment on lines
+3
to
+7
| * Update plusplayer | ||
| 1. [HLS] Fix for sigsegv when external track in content. | ||
| 2. [HLS] Fix for Memory increase after discontinuity due to wrong content format received for cmaf content. | ||
| 3. [HLS] MA Handling for Invalid Cmaf Segment. | ||
| 4. [HLS] Added log for checking ad drift, printing manifest start time and json start time of the ad. |
There was a problem hiding this comment.
To improve readability for package consumers, consider rephrasing the changelog entry to be more descriptive and less technical. The current notes appear to be internal development notes. Per the repository style guide, documentation should be useful. Making these notes more user-friendly would increase the quality of the documentation.
Suggested change
| * Update plusplayer | |
| 1. [HLS] Fix for sigsegv when external track in content. | |
| 2. [HLS] Fix for Memory increase after discontinuity due to wrong content format received for cmaf content. | |
| 3. [HLS] MA Handling for Invalid Cmaf Segment. | |
| 4. [HLS] Added log for checking ad drift, printing manifest start time and json start time of the ad. | |
| * Updates `plusplayer` to include the following HLS-related improvements: | |
| * Fixed a crash (`SIGSEGV`) when using content with external tracks. | |
| * Fixed a memory leak that occurred after a discontinuity with CMAF content. | |
| * Improved handling of invalid CMAF segments. | |
| * Added logs for debugging ad drift, including manifest and ad JSON start times. |
References
- The style guide states that documentation should be useful. The suggested change improves the usefulness of the changelog by making it more readable and understandable for end-users. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes: