Prevent accessing destroyed AccessibilityChannel in async callbacks#158
Open
JSUYA wants to merge 3 commits intoflutter-tizen:masterfrom
Open
Prevent accessing destroyed AccessibilityChannel in async callbacks#158JSUYA wants to merge 3 commits intoflutter-tizen:masterfrom
JSUYA wants to merge 3 commits intoflutter-tizen:masterfrom
Conversation
Add shutdown flag to prevent async callbacks from executing after the AccessibilityChannel instance has been destroyed. This fixes potential dangling pointer issues in OnAccessibilityBusAddressGet and OnSessionBusConnection callbacks.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to prevent asynchronous callbacks from accessing a destroyed AccessibilityChannel instance by introducing a shutdown_ flag. However, the current implementation is flawed as checking the shutdown_ flag on a destroyed object introduces a Use-After-Free (UAF) vulnerability. This approach may still lead to undefined behavior by dereferencing a dangling pointer. A safer and more robust alternative using GCancellable to manage the async operation lifecycle is recommended. Additionally, the PR includes positive improvements such as better validation of DBus response types and socket addresses.
gin7773
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents a crash if the callback is called after the AccessibilityChannel instance has been destroyed.