Update the docsify package that's used in the user documentation#5872
Merged
canova merged 2 commits intofirefox-devtools:mainfrom Mar 2, 2026
Merged
Update the docsify package that's used in the user documentation#5872canova merged 2 commits intofirefox-devtools:mainfrom
canova merged 2 commits intofirefox-devtools:mainfrom
Conversation
We stopped using google analytics a very long time ago. But it looks like the ga docsify plugin was still loaded even though it wasn't used. This commit removes this plugin
This commit updates the docsify plugin to its latest released version, v4.13.1. But it looks like this PR is not in this release yet: docsifyjs/docsify#2586 Since it's nice to have it, these minified JS code has this PR applied as well.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5872 +/- ##
=======================================
Coverage 85.56% 85.56%
=======================================
Files 319 319
Lines 31499 31499
Branches 8705 8697 -8
=======================================
Hits 26953 26953
Misses 4115 4115
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
approved these changes
Mar 2, 2026
fatadel
approved these changes
Mar 2, 2026
Merged
canova
added a commit
that referenced
this pull request
Mar 3, 2026
Changes: [fatadel] Fix crash when nativeSymbol index is out of bounds in assembly view (#5850) [depfu[bot]] Update all Yarn dependencies (2026-02-25) (#5859) [Nazım Can Altınova] Fix the color of dark mode back arrow svg (#5863) [fatadel] Force canvas redraw when system theme changes (#5861) [Nazım Can Altınova] Fix unhandled promise rejection in setupInitialUrlState (#5864) [fatadel] Persist selected marker in URL and show sticky tooltip on load (#5847) [Markus Stange] Implement the "collapse resource" transform with the help of the "collapse direct recursion" transform. (#5824) [Markus Stange] Bump rollup from 2.79.2 to 2.80.0 (#5868) [Markus Stange] Remove async attribute from module script tag. (#5870) [Nazım Can Altınova] Update the docsify package that's used in the user documentation (#5872) [Markus Stange] Share stackTable, frameTable, funcTable, resourceTable and nativeSymbols between threads (#5482) [Nazım Can Altınova] Escape CSS URLs that are coming from profiles (#5874) [fatadel] Update home page message for the other browser case (#5866) [fatadel] Add support for ternaries in marker labels (#5857) [Markus Stange] Reduce allocations for getStackLineInfo + getStackAddressInfo (#5761) And special thanks to our localizers: de: Ger fy-NL: Fjoerfoks it: Francesco Lodolo [:flod] nl: Fjoerfoks ru: berry ru: Valery Ledovskoy zh-TW: Pin-guang Chen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use docsify in the user documentation. It looks like our plugin has been out of date for a while.
This PR:
But apart from this, I'm not happy with the docsify plugin overall. The whole process is very tricky and we always had to manually patch it. Ideally we should switch off to a better maintained plugin. I'll file an issue about that one.