Use streaming JSON parser for profile fetch#5843
Use streaming JSON parser for profile fetch#5843pepyakin wants to merge 2 commits intofirefox-devtools:mainfrom
Conversation
|
Hey there @canova . Is there anything I can do to help pushing this in? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5843 +/- ##
==========================================
- Coverage 85.56% 85.55% -0.01%
==========================================
Files 319 319
Lines 31411 31494 +83
Branches 8670 8588 -82
==========================================
+ Hits 26876 26944 +68
- Misses 4104 4119 +15
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I haven't looked in any detail yet, but I tried the deploy preview with a large-but-not-too-large profile and I still see the old path being used: https://deploy-preview-5578--perf-html.netlify.app/public/fkmw9djz29ntsmaznezy93hhft85jy0zjrp5my8/calltree/?globalTrackOrder=0&profileName=FullSp3Firefox-15x-symbolicated&thread=0&v=12 Is this expected? I would like to compare the performance. |
When using
samplywith large profiles you can sometimes get very large profiles. If an uncompressed profile gets large enough it will get silently truncated and the profile cannot be displayed (see the screenshot attached). As was noted by @mhansen, it's probably theStringlimit as described here.In any case, this PR attempts to fix this issue by using a streaming JSON parser instead of trying to swallow the trace awhole.