Skip to content

chore(deps): remove unused thiserror from ev-precompiles#153

Open
randygrok wants to merge 1 commit intomainfrom
randygrok/rm-thiserror-precompiles
Open

chore(deps): remove unused thiserror from ev-precompiles#153
randygrok wants to merge 1 commit intomainfrom
randygrok/rm-thiserror-precompiles

Conversation

@randygrok
Copy link
Contributor

@randygrok randygrok commented Mar 2, 2026

Description

Remove unused thiserror dependency from the ev-precompiles crate. The library was declared in Cargo.toml but never imported or used in any source file.

@randygrok randygrok requested a review from a team as a code owner March 2, 2026 16:50
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Warning

Rate limit exceeded

@randygrok has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 16 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2d61625 and 46cd99f.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • CHANGELOG.md
  • crates/ev-precompiles/Cargo.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch randygrok/rm-thiserror-precompiles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link

claude bot commented Mar 2, 2026

Claude finished @randygrok's task —— View job


PR Review: Remove unused thiserror dependency

Reviewing this dependency cleanup PR:

Todo List:

  • Read and analyze changed files
  • Verify thiserror is truly unused in ev-precompiles crate
  • Check for potential issues with the removal
  • Provide comprehensive review feedback

Analysis

I've analyzed the PR and can confirm this is a clean dependency removal:

Code Quality & Best Practices

  • Correct identification: The thiserror = "1.0.58" dependency was indeed declared in Cargo.toml but never used
  • Complete removal: All references removed properly (dependency + lockfile update)
  • Documentation: CHANGELOG.md appropriately updated in unreleased section

Verification of Non-Usage

I verified thiserror is completely unused by:

  • Direct search: No imports or usage of thiserror crate in any source files
  • Macro inspection: No #[derive(Error)] or #[error(...)] attributes found
  • Error handling review: The code uses PrecompileError::Other(msg.into()) for error construction in mint.rs:50-52, mint.rs:93-94, mint.rs:107-108, etc.

No Issues Identified

Potential bugs or issues: None. The removal is safe since:

  • No compilation dependencies on thiserror
  • Error handling uses existing PrecompileError infrastructure
  • All error cases use simple string conversion via .to_string().into()

Performance considerations: ✅ Positive impact

  • Reduces dependency tree size
  • Faster compile times
  • Smaller binary size

Security concerns: None. This is a pure removal with no functional changes.

Test coverage: The comprehensive test suite in mint.rs:261-751 covers all error scenarios and doesn't rely on thiserror functionality.

📋 Recommendation

APPROVE - This is an excellent cleanup PR that:

  • Properly removes unused dependencies
  • Follows semantic versioning (patch-level change)
  • Updates documentation correctly
  • Has no functional impact on the codebase

The removal is completely safe and improves the project's dependency hygiene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants