Skip to content

build(deps): bump core v1.0.0#3135

Merged
julienrbrt merged 1 commit intomainfrom
julien/core-v1
Mar 5, 2026
Merged

build(deps): bump core v1.0.0#3135
julienrbrt merged 1 commit intomainfrom
julien/core-v1

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 4, 2026

Bump to core v1

Summary by CodeRabbit

  • Chores
    • Updated core dependencies from pre-release versions to stable v1.0.0 releases across all application modules and testing configurations for increased reliability
    • Refined module resolution strategy by removing local development path overrides and adopting standard module proxy resolution for consistent dependency handling
    • Improved overall system stability through unified dependency management practices

@julienrbrt julienrbrt requested a review from tac0turtle March 4, 2026 20:13
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedMar 4, 2026, 8:13 PM

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 02be33e9-ec18-4cb0-ba12-b215a0c46c64

📥 Commits

Reviewing files that changed from the base of the PR and between c0bc141 and 14af6f0.

⛔ Files ignored due to path filters (9)
  • apps/evm/go.sum is excluded by !**/*.sum
  • apps/grpc/go.sum is excluded by !**/*.sum
  • apps/testapp/go.sum is excluded by !**/*.sum
  • execution/evm/go.sum is excluded by !**/*.sum
  • execution/evm/test/go.sum is excluded by !**/*.sum
  • execution/grpc/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • test/docker-e2e/go.sum is excluded by !**/*.sum
  • test/e2e/go.sum is excluded by !**/*.sum
📒 Files selected for processing (9)
  • apps/evm/go.mod
  • apps/grpc/go.mod
  • apps/testapp/go.mod
  • execution/evm/go.mod
  • execution/evm/test/go.mod
  • execution/grpc/go.mod
  • go.mod
  • test/docker-e2e/go.mod
  • test/e2e/go.mod

📝 Walkthrough

Walkthrough

This pull request coordinates a version promotion across multiple Go modules in the project. The dependency github.com/evstack/ev-node/core is updated from the prerelease version v1.0.0-rc.1 to the stable version v1.0.0. Simultaneously, local replace directives that pointed ev-node/core to local filesystem paths are removed, transitioning module resolution from development overrides to the official module proxy.

Changes

Cohort / File(s) Summary
Root and App Modules
go.mod, apps/evm/go.mod, apps/grpc/go.mod, execution/grpc/go.mod
Updated github.com/evstack/ev-node/core from v1.0.0-rc.1 to v1.0.0 and removed the local replace directive mapping to ../../core or ./core.
Test and Execution Modules
apps/testapp/go.mod, execution/evm/go.mod, execution/evm/test/go.mod, test/docker-e2e/go.mod, test/e2e/go.mod
Updated github.com/evstack/ev-node/core from v1.0.0-rc.1 to v1.0.0 and simplified or removed local replace directives for the core module, retaining other module replacements where applicable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 The core module hops from RC to stable ground,
No more local paths in our replace block found.
Nine modules aligned, with versions so clean,
v1.0.0 stable—the best we've seen! 🌱

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description 'Bump to core v1' is minimal but captures the essential change; however, it lacks required context, background, and rationale expected by the template's Overview section. Expand the description to include context (why upgrade now), background (current state), and rationale (benefits of v1.0.0 over rc.1) to fully comply with template requirements.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'build(deps): bump core v1.0.0' clearly and concisely describes the main change: upgrading the core dependency from v1.0.0-rc.1 to v1.0.0, which aligns with the changeset across all go.mod files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch julien/core-v1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link
Contributor

claude bot commented Mar 4, 2026

Claude finished @julienrbrt's task in 1m 14s —— View job


Code Review: build(deps): bump core v1.0.0

  • Gather context and analyze PR changes
  • Review go.mod changes across all modules
  • Assess dependency changes and potential impacts
  • Provide final review summary

Summary

This PR promotes github.com/evstack/ev-node/core from v1.0.0-rc.1 to the stable v1.0.0 release across all 9 go.mod files in the monorepo. The primary structural change beyond the version bump is the removal of all local replace directives pointing github.com/evstack/ev-node/core to the local ./core directory.

What Changed

File Change
go.mod core v1.0.0-rc.1v1.0.0, removed replace github.com/evstack/ev-node/core => ./core
apps/evm/go.mod core v1.0.0-rc.1v1.0.0, removed replace .../core => ../../core
apps/grpc/go.mod Same pattern
apps/testapp/go.mod Same pattern
execution/evm/go.mod Same pattern
execution/evm/test/go.mod Same pattern
execution/grpc/go.mod Version bump only
test/docker-e2e/go.mod Version bump only
test/e2e/go.mod Same pattern

Observations

Correct and clean change. The removals of replace directives are the expected outcome of graduating core to a stable published release. All 9 modules are updated consistently.

One thing worth noting: The ./core directory still lives in the monorepo, but no module now has a local replace pointing to it. This means any in-progress local changes to ./core will be invisible to builds — the published v1.0.0 will be used instead. This is intentional for a stable release, but it does add friction if core ever needs a patch alongside changes in the main module during development. The team would need to temporarily re-add the replace directives in that case (as was done during rc development).

Consistency across modules: All modules that previously had replace github.com/evstack/ev-node/core => <path> have had those directives removed. No stragglers.

Note on execution/grpc and test/docker-e2e: These modules don't have a replace for the main ev-node module either (they reference v1.0.0-rc.4 as a real dependency), which is a pre-existing pattern not introduced here.

Buf CI passed, confirming no protobuf breaking changes in core v1.0.0.

Verdict

This is a clean, mechanical dependency promotion. The changes are correct and consistent. No issues found.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.81%. Comparing base (c0bc141) to head (14af6f0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3135      +/-   ##
==========================================
- Coverage   60.87%   60.81%   -0.06%     
==========================================
  Files         113      113              
  Lines       11695    11695              
==========================================
- Hits         7119     7112       -7     
- Misses       3773     3778       +5     
- Partials      803      805       +2     
Flag Coverage Δ
combined 60.81% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrbrt julienrbrt added this pull request to the merge queue Mar 5, 2026
Merged via the queue into main with commit 5a07bc3 Mar 5, 2026
33 checks passed
@julienrbrt julienrbrt deleted the julien/core-v1 branch March 5, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants