Conversation
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis pull request coordinates a version promotion across multiple Go modules in the project. The dependency Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @julienrbrt's task in 1m 14s —— View job Code Review:
|
| File | Change |
|---|---|
go.mod |
core v1.0.0-rc.1 → v1.0.0, removed replace github.com/evstack/ev-node/core => ./core |
apps/evm/go.mod |
core v1.0.0-rc.1 → v1.0.0, removed replace .../core => ../../core |
apps/grpc/go.mod |
Same pattern |
apps/testapp/go.mod |
Same pattern |
execution/evm/go.mod |
Same pattern |
execution/evm/test/go.mod |
Same pattern |
execution/grpc/go.mod |
Version bump only |
test/docker-e2e/go.mod |
Version bump only |
test/e2e/go.mod |
Same pattern |
Observations
Correct and clean change. The removals of replace directives are the expected outcome of graduating core to a stable published release. All 9 modules are updated consistently.
One thing worth noting: The ./core directory still lives in the monorepo, but no module now has a local replace pointing to it. This means any in-progress local changes to ./core will be invisible to builds — the published v1.0.0 will be used instead. This is intentional for a stable release, but it does add friction if core ever needs a patch alongside changes in the main module during development. The team would need to temporarily re-add the replace directives in that case (as was done during rc development).
Consistency across modules: All modules that previously had replace github.com/evstack/ev-node/core => <path> have had those directives removed. No stragglers.
Note on execution/grpc and test/docker-e2e: These modules don't have a replace for the main ev-node module either (they reference v1.0.0-rc.4 as a real dependency), which is a pre-existing pattern not introduced here.
Buf CI passed, confirming no protobuf breaking changes in core v1.0.0.
Verdict
This is a clean, mechanical dependency promotion. The changes are correct and consistent. No issues found.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3135 +/- ##
==========================================
- Coverage 60.87% 60.81% -0.06%
==========================================
Files 113 113
Lines 11695 11695
==========================================
- Hits 7119 7112 -7
- Misses 3773 3778 +5
- Partials 803 805 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bump to core v1
Summary by CodeRabbit