Skip to content

refactor(render-mode-property): update HTML structure and styling for…#34827

Merged
nicobytes merged 5 commits intomainfrom
34825-ui-inconsistencies-in-login-toggle-cards-and-sidebar
Mar 3, 2026
Merged

refactor(render-mode-property): update HTML structure and styling for…#34827
nicobytes merged 5 commits intomainfrom
34825-ui-inconsistencies-in-login-toggle-cards-and-sidebar

Conversation

@nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Mar 2, 2026

… improved UX

  • Replaced div elements with p-card for render mode options to enhance visual consistency.
  • Adjusted CSS classes for better alignment with Tailwind CSS standards.
  • Updated error and success message styling in the login component for clearer user feedback.
  • Removed unused background color property in navigation header styles.

These changes aim to streamline the user interface and improve overall user experience across components.

Screenshots

Original Updated
localhost_8080_dotAdmin_(MacBook Pro 14) (2) localhost_4200_dotAdmin_logout_r=1772473402669(MacBook Pro 14)
image image
image image

Related #34825

This PR fixes: #34825

… improved UX

- Replaced div elements with p-card for render mode options to enhance visual consistency.
- Adjusted CSS classes for better alignment with Tailwind CSS standards.
- Updated error and success message styling in the login component for clearer user feedback.
- Removed unused background color property in navigation header styles.

These changes aim to streamline the user interface and improve overall user experience across components.
@nicobytes nicobytes linked an issue Mar 2, 2026 that may be closed by this pull request
@nicobytes nicobytes requested review from Copilot, hmoreras and oidacra and removed request for Copilot March 2, 2026 17:52
@github-actions github-actions bot added the Area : Frontend PR changes Angular/TypeScript frontend code label Mar 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors a few UI components in dotcms-ui to improve visual consistency and UX by aligning render mode selection with PrimeNG card styling, updating message color feedback on the login page, and simplifying navigation header styling.

Changes:

  • Replaced render mode option containers with p-card and updated Tailwind utility classes.
  • Updated login message styling to use Tailwind text color utilities instead of ngClass.
  • Removed an unused background-color from the nav header button wrapper styles.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
core-web/apps/dotcms-ui/src/app/view/components/login/dot-login-component/dot-login.component.html Adjusts error/success message styling via Tailwind class bindings.
core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/components/dot-nav-header/dot-nav-header.component.scss Removes a background color from the nav header button wrapper.
core-web/apps/dotcms-ui/src/app/portlets/shared/dot-content-types-edit/components/fields/content-type-fields-properties-form/field-properties/render-mode-property/render-mode-property.component.html Refactors render mode selection UI to use p-card with updated Tailwind classes.

@nicobytes nicobytes added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 87edaf6 Mar 3, 2026
22 checks passed
@nicobytes nicobytes deleted the 34825-ui-inconsistencies-in-login-toggle-cards-and-sidebar branch March 3, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area : Frontend PR changes Angular/TypeScript frontend code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

UI Inconsistencies in Login, Toggle Cards, and Sidebar

5 participants