34817 add utf8 test cases and fix broken tag test cases#34819
Open
hassandotcms wants to merge 6 commits intomainfrom
Open
34817 add utf8 test cases and fix broken tag test cases#34819hassandotcms wants to merge 6 commits intomainfrom
hassandotcms wants to merge 6 commits intomainfrom
Conversation
Fix 3 broken tests (201→200 response contract from #34604). Add 5 UTF-8 tests for create, rename, import, export, round-trip. Register TagResourceIntegrationTest in MainSuite1b for CI.
hassandotcms
requested review from
fabrizzio-dotCMS,
jcastro-dotcms and
nollymar
fabrizzio-dotCMS
approved these changes
Mar 4, 2026
dotcms-integration/src/test/java/com/dotcms/rest/api/v2/tags/TagResourceIntegrationTest.java
Show resolved
Hide resolved
dotcms-integration/src/test/java/com/dotcms/rest/api/v2/tags/TagResourceIntegrationTest.java
Show resolved
Hide resolved
- Replace hardcoded \n with %n format specifier in buildCsv() method - Ensures correct line endings on all platforms (Windows: \r\n, Unix: \n) - Addresses PR feedback for cross-platform compatibility
…utf8-test-cases-fix-broken-tag-test-cases
jcastro-dotcms
approved these changes
Mar 5, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots
fixes: #34817