scripts/warn-outside-container: fix font representation#6839
scripts/warn-outside-container: fix font representation#6839literally-user wants to merge 1 commit intodocker:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! I recall we had a PR for this, but it had some issues (#4211), so we can go with your PR instead; however, it looks like shellcheck linting is failing; can you fix that? (please amend the commit, so that there's only one commit in the PR)
|
Oh, i see! Yeah, i'll fix that asap |
8f44542 to
914fd74
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! I just tried, and looks like there was an issue; I posted the correct variant (you can copy/paste it.
| printf "\n" | ||
| printf "\033[1mWARNING\033[0m: you are not in a container." | ||
| printf | ||
| printf 'Use "\033[1mmake dev\033[0m" to start an interactive development container,' | ||
| printf 'use "\033[1mmake -f docker.Makefile %s\033[0m" to execute this target' "$target" | ||
| printf "in a container, or set \033[1mDISABLE_WARN_OUTSIDE_CONTAINER=1\033[0m to" | ||
| printf "disable this warning." | ||
| printf | ||
| printf "Press \033[1mCtrl+C\033[0m now to abort, or wait for the script to continue.." | ||
| printf "\n" |
There was a problem hiding this comment.
Some printf's didn't have an argument, causing a failure;
make binary WARNING: you are not in a container.printf: usage: printf [-v var] format [arguments] ./scripts/build/binaryWe should also preserve the newlines (which echo automatically added); this should probably be the right one;
printf "\n"
printf "\033[1mWARNING\033[0m: you are not in a container.\n"
printf "\n"
printf 'Use "\033[1mmake dev\033[0m" to start an interactive development container,\n'
printf 'use "\033[1mmake -f docker.Makefile %s\033[0m" to execute this target\n' "$target"
printf "in a container, or set \033[1mDISABLE_WARN_OUTSIDE_CONTAINER=1\033[0m to\n"
printf "disable this warning.\n"
printf "\n"
printf "Press \033[1mCtrl+C\033[0m now to abort, or wait for the script to continue..\n"Signed-off-by: Davlat Davydov <literally_user@hotmail.com> fix CI review changes
914fd74 to
71db152
Compare
|
Fixed. Thanks for your patience! |
Fixed font display in /scripts/warn-outside-container by replacing echo with POSIX-compatible prinf so that display works on any POSIX-compatible systems.
Fixes #6838