fix(jsbn): prevent modInverse hang for zero input#1136
Open
Kr0emer wants to merge 1 commit intodigitalbazaar:mainfrom
Open
fix(jsbn): prevent modInverse hang for zero input#1136Kr0emer wants to merge 1 commit intodigitalbazaar:mainfrom
Kr0emer wants to merge 1 commit intodigitalbazaar:mainfrom
Conversation
Contributor
|
@davidlehn - would like you to review when possible. The patch seems very reasonable. |
Author
Thanks @sei-vsarvepalli. The previous PR was submitted to the wrong location. I've resubmitted the fix under the correct advisory page: https://github.com/digitalbazaar/forge/security/advisories/GHSA-5m6q-g25r-mvwx @davidlehn please review when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a hang in
jsbnwhen callingBigInteger#modInversewith a zero value.When
this == 0andmis odd/non-zero (for example0.modInverse(3)),bnModInverse()can enter an infinite loop in thewhile(v.isEven())path, causing a potential DoS.Root Cause
vis initialized asthis.clone().If
thisis zero,vstays zero forever, and right-shifting zero never changes it, so the loop does not terminate.Fix
Add an early zero-input guard at the entry of
bnModInverse():if(this.signum() == 0) return BigInteger.ZERO;This keeps existing
jsbnbehavior for non-invertible cases (returningBigInteger.ZERO) and avoids introducing a breaking API change.Tests
Added a regression test:
tests/unit/jsbn.jstests/unit/index.jsThe new test verifies
BigInteger(0).modInverse(3)returns0and does not hang.