Skip to content

Extend benchmark logging to include build and search compressor information#641

Open
tlwillke wants to merge 1 commit intomainfrom
logging-improvements
Open

Extend benchmark logging to include build and search compressor information#641
tlwillke wants to merge 1 commit intomainfrom
logging-improvements

Conversation

@tlwillke
Copy link
Collaborator

@tlwillke tlwillke commented Mar 5, 2026

This extends the v1 experiments.csv schema with build_compressor and search_compressor columns so logged runs record the resolved compressor configurations used during index build and search. Values use the compressor’s printable toString() (e.g., ProductQuantization[...]) and are CSV-escaped to preserve commas. Search compressor logging is null-safe when compression is disabled (cv == null).
build-and-search-compressor-info

@tlwillke tlwillke requested a review from ashkrisk March 5, 2026 00:53
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

Copy link
Contributor

@ashkrisk ashkrisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Eventually it would be nice to have compressor parameters separated by column, but we can look into it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants