Wire HostMetadata discovery into DatabricksConfig#680
Open
hectorcast-db wants to merge 4 commits intomainfrom
Open
Wire HostMetadata discovery into DatabricksConfig#680hectorcast-db wants to merge 4 commits intomainfrom
hectorcast-db wants to merge 4 commits intomainfrom
Conversation
Adds `HostMetadata` and a package-private `getHostMetadata()` on
`DatabricksConfig` for parsing the `/.well-known/databricks-config`
discovery endpoint.
The method returns raw metadata with no substitution (e.g.
`{account_id}` placeholders are left as-is), keeping it a pure
discovery primitive. Callers decide how to interpret the result.
Adds tests covering: - DATABRICKS_DISCOVERY_URL env var is loaded into Config - getDatabricksOidcEndpoints() short-circuits to discoveryUrl when set The underlying implementation (discoveryUrl config field and getDatabricksOidcEndpoints() short-circuit) was already present in the Java SDK. Mirrors the Python SDK's get_endpoints_from_url() addition.
Adds package-private `resolveHostMetadata()` to `DatabricksConfig`.
When called, it fetches `/.well-known/databricks-config` and back-fills
`accountId`, `workspaceId`, and `discoveryUrl` (with any `{account_id}`
placeholder substituted) if those fields are not already set.
Raises DatabricksException if `accountId` cannot be resolved or if no
`oidc_endpoint` is present in the metadata. Mirrors
`Config._resolve_host_metadata()` in the Python SDK.
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Summary
Wires host metadata discovery into
DatabricksConfigvia a new package-privateresolveHostMetadata()helper, mirroringConfig._resolve_host_metadata()in the Python SDK.Why
Users configuring the SDK today have no way to let it auto-discover
accountId,workspaceId, or the OIDC endpoint from the host — they must supply each field manually. ThediscoveryUrlconfig property already allows providing a direct OIDC discovery URL;resolveHostMetadata()completes the picture by deriving all three fields automatically from the host's/.well-known/databricks-configendpoint.What changed
Interface changes
DatabricksConfig.resolveHostMetadata()(package-private) — CallsgetHostMetadata()on the configured host and back-fillsaccountId,workspaceId, anddiscoveryUrl(with any{account_id}placeholder substituted) if those fields are not already set. ThrowsDatabricksExceptionifaccountIdcannot be resolved or if nooidc_endpointis present in the metadata.Behavioral changes
resolveHostMetadata()is not called automatically — it is opt-in.Internal changes
Tests in
DatabricksConfigTest:testResolveHostMetadataWorkspacePopulatesAllFields— workspace populates all three fields.testResolveHostMetadataAccountSubstitutesAccountId— account host substitutes{account_id}in the OIDC endpoint.testResolveHostMetadataDoesNotOverwriteExistingFields— existing fields are not overwritten.testResolveHostMetadataRaisesWhenAccountIdUnresolvable— raises whenaccountIdcannot be resolved.testResolveHostMetadataRaisesWhenOidcEndpointMissing— raises whenoidc_endpointis absent.testResolveHostMetadataRaisesOnHttpError— raises when the well-known endpoint returns an error.How is this tested?
Unit tests in
DatabricksConfigTestusingFixtureServer.NO_CHANGELOG=true