Merged
Conversation
JList is initialized with 0 or 1 arguments. The original is this:
if (arguments.length === 1) {
sequence.push(arguments[0]);
}
If an argument is passed, it is added. The new code mimics this.
The second issue is in the wildard handling. In the list case, arrays
need to be flattended. The issue comes from the unnecessary handling of
maps. Like scalar types, those simply need to be added to the result
uw4
approved these changes
Oct 20, 2025
Contributor
uw4
left a comment
uw4
left a comment
There was a problem hiding this comment.
LGTM
This brings Java nearer to the original JS
| else | ||
| // This case does NOT exist in Javascript! Why? | ||
| sequence.add(el); | ||
| sequence.add(el); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JList is initialized with 0 or 1 arguments. The original is this:
if (arguments.length === 1) {
sequence.push(arguments[0]);
}
If an argument is passed, it is added. The new code mimics this.
The second issue is in the wildard handling. In the list case, arrays need to be flattended. The issue comes from the unnecessary handling of maps. Like scalar types, those simply need to be added to the result