Fix: Enable exception mode to skip scripts on first error#1258
Open
glensc wants to merge 2 commits intodanger:mainfrom
Open
Fix: Enable exception mode to skip scripts on first error#1258glensc wants to merge 2 commits intodanger:mainfrom
glensc wants to merge 2 commits intodanger:mainfrom
Conversation
This was referenced Mar 18, 2022
Member
|
I'm wary about this breaking on Windows - have you tried it there? The CI doesn't look to be running any of these commands |
Contributor
Author
|
Using "; " separator is not new. Some scripts already used those. And I do not have any windows platform access. |
Contributor
Author
|
Same problem in other projects in this organization: |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1254
Noticed that "danger:prepush" ran commands with ";" rather "&&" meaning the next command is still executed if the previous one failed. This resulted in very weird errors due to the previous step failure.
Now, aborts of first error: