Merged
Conversation
Allows themes to customize margin values used for spacing between content elements. Includes translations for the scale labels. REDMINE-21191
REDMINE-21191
tf
force-pushed
the
margins
branch
4 times, most recently
from
b7af70d to
8ec57d8
Compare
Enable CSS-based margin collapsing by exposing margin values as custom properties (--margin-top, --prev-margin-bottom) instead of inline styles. The CSS now uses max() to pick the larger of the current element's top margin and the previous element's bottom margin. Only inline elements participate in margin tracking - side/sticky elements are skipped when determining the previous margin bottom. REDMINE-21191
REDMINE-21191
Render a label element so the inputView mixin can display a translated label. Existing usages pass hideLabel to keep their current appearance. The style list input unconditionally pulled itself up via negative margin-top. Make this conditional on the hideLabel option so it only compensates for a hidden label when one is actually hidden. REDMINE-21191
Allow style types to use values/texts arrays for sliders with predefined steps instead of continuous min/max ranges. Discrete sliders save on slide for immediate feedback. REDMINE-21191
Replace individual select inputs with a unified style list input that editors can use to add margin styles. This aligns the margin configuration UI with the pattern used for image modifiers. REDMINE-21191
Allow style types to specify a propertyName so their value is stored directly on the model (e.g. marginTop: 'md') instead of inside the serialized styles array. This keeps margin data compatible with the previous select inputs. REDMINE-21191
Show diagonal stripe overlays with scale text tooltips on top/bottom margins when a content element is selected in the editor. Only rendered when the content_element_margins feature is enabled and a margin value is explicitly configured. REDMINE-21191
REDMINE-21191
When removing a style whose type defines a resetValue, set the model property to that value instead of unsetting it. This prevents regressions for content elements like heading which rely on the presence of marginTop in configuration (e.g. for forcePaddingTop). getTypesForContentElement now accepts the content element and derives resetValue from its defaultConfig, so the heading's defaultConfig marginTop of 'none' is preserved when the margin style is removed from the list. REDMINE-21191
Prevents the built-in subtitle bottom margin from overriding a custom bottom margin set via the style list. REDMINE-21191
Elements with width sm or smaller should share a layout group with md-width elements so they are rendered inside the same content box rather than being separated into individual boxes. REDMINE-21191
When the last content element in a card box has a custom bottom margin, the card's built-in bottom padding is suppressed to avoid double spacing. The card's margin and border radius at the end are preserved. REDMINE-21191
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21191