Add keyboard shortcuts help modal with centralized config#3
Open
Add keyboard shortcuts help modal with centralized config#3
Conversation
|
@ThomasK33 must be a member of the Coder team on Vercel to deploy. Learn more about collaboration on Vercel and other options here. |
ThomasK33
force-pushed
the
feat/keyboard-shortcuts-modal
branch
2 times, most recently
from
f7e6f65 to
4982509
Compare
Member
|
@ThomasK33 can you post screenshot pls |
Member
Author
|
- Add `?` hotkey to open a modal showing all available shortcuts - Create centralized shortcuts config in src/browser/lib/shortcuts.ts - Modal auto-generates from config (no manual sync needed) - Update all keyboard handlers to use matchesKey() utility - Shortcuts organized by category: Navigation, Actions, Go to Line, File Search, Tabs, Help Change-Id: I4c7d8b209ed70901f7b6e3c61c275a34207f7369 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Change-Id: If0ba43b175821808ac897cd08e0a82f3af04c91e Signed-off-by: Thomas Kosiewski <tk@coder.com>
ThomasK33
force-pushed
the
feat/keyboard-shortcuts-modal
branch
from
4982509 to
97ca37c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?hotkey to open a modal showing all available keyboard shortcutsmatchesKey()utility for consistencyChanges
New files:
src/browser/lib/shortcuts.ts— Central config with types, definitions, and utilitiessrc/browser/components/keyboard-shortcuts-modal.tsx— Modal componentModified files:
src/browser/components/app-shell.tsx— Add?listener and render modalsrc/browser/components/command-palette.tsx— UsematchesKey()for Cmd+K/Psrc/browser/contexts/pr-review/useKeyboardNavigation.ts— UsematchesKey()for all PR review shortcutsTest plan
?anywhere in the app (not in an input) — modal should openEscapeor click outside to close the modal