Keep Initializr loader visible until CN1 UI ready#4576
Merged
shai-almog merged 2 commits intomasterfrom Feb 26, 2026
Merged
Conversation
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
docs/website/layouts/_default/initializr.htmlnow waits for apostMessagewith typecn1-initializr-ui-readyor an 8s iframe-load fallback before hiding the overlay instead of hiding immediately oniframe.load.notifyUiReady()method to theWebsiteThemeNativeinterface inscripts/initializr/common/src/main/java/com/codename1/initializr/WebsiteThemeNative.java.notifyWebsiteUiReady()(which invokes the native bridge) immediately afterform.show()inscripts/initializr/common/src/main/java/com/codename1/initializr/Initializr.javaso the parent page receives the ready signal as soon as the CN1 form is visible.notifyUiReady_inscripts/initializr/javascript/src/main/javascript/com_codename1_initializr_WebsiteThemeNative.jstopostMessage()the readiness event to the parent page.Testing
mvn -f scripts/initializr/pom.xml -pl common -am -DskipTests compile, which progressed but failed during an Ant task that downloadsUpdateCodenameOne.jardue to network unreachability in this environment (build failed withjava.net.SocketException: Network is unreachable)../mvnw -pl common test -DskipITsandmvn -f scripts/initializr/pom.xml -pl common -DskipTests compile -o; these failed due to wrapper/network/offline plugin resolution issues in this environment, so runtime validation on a live page was not possible here.Keep Initializr loader style consistent until UI is ready).Codex Task