Fix bug in client to also use project id when getting VM by name#5
Open
elivlo wants to merge 1 commit intocloudstack:mainfrom
Open
Fix bug in client to also use project id when getting VM by name#5elivlo wants to merge 1 commit intocloudstack:mainfrom
elivlo wants to merge 1 commit intocloudstack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The client only uses the project ID in the function
GetVMByIDand not in the functiongetVMByName.This causes the CSI where the instance ID is not found in the metadata and the VM is in a project to fail. Eventually they fall back into a crash loop backoff and the CSI is not usable.
I changes the two functions to call the new function
getVMByParamand reduce code duplication. The new function requires a setter function as argument where the parameter, either id or name, is then set.Testing performed:
I installed k8s into Cloudstack with a project and without. The setup of the CSI worked when running in the root project but not in sub projects.
Please create a bugfix release when the PR is approved and merged.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.