Skip to content

fix: too strict validation#4017

Merged
tpoisseau merged 8 commits intomainfrom
4002-panels-display-validation-too-strict
Mar 4, 2026
Merged

fix: too strict validation#4017
tpoisseau merged 8 commits intomainfrom
4002-panels-display-validation-too-strict

Conversation

@tpoisseau
Copy link
Contributor

@tpoisseau tpoisseau commented Feb 27, 2026

fix: too strict validation (#4017)

best effort to support invalid workspace

Closes: https://github.com/cheminfo/nmrium/issues/4002

fix: the form submit (#4017)

Use a replace strategy for arrays instead of merge

Refs: https://github.com/cheminfo/nmrium/issues/4006

fix: reset form with encoded workspace (#4017)

fix: handleAddWorkspace by parsing form values (#4017)

Closes: https://github.com/cheminfo/nmrium/issues/4006

refactor: header to use withForm (#4017)

instead passing reset and current values props with broken types 

best effort to support invalid workspace

Closes: #4002

fix: the form submit

Use a replace strategy for arrays instead of merge

Refs: #4006
fix: handleAddWorkspace by parsing form values

refactor: header to use withForm instead passing reset and current values props with broken types

Closes: #4006
@tpoisseau tpoisseau linked an issue Feb 27, 2026 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 27, 2026

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4b7c01b
Status: ✅  Deploy successful!
Preview URL: https://e925c3f4.nmrium.pages.dev
Branch Preview URL: https://4002-panels-display-validati.nmrium.pages.dev

View logs

@tpoisseau
Copy link
Contributor Author

Time for deep testing.

Once everything is OK with this form, We will be able to replace original form with this one.

@targos
Copy link
Member

targos commented Mar 2, 2026

Note that I already made a small review pass and opened a couple of sub-issues on #3932 before this PR

@stropitek

This comment was marked as resolved.

@stropitek

This comment was marked as resolved.

@stropitek

This comment was marked as resolved.

@tpoisseau
Copy link
Contributor Author

Note that I already made a small review pass and opened a couple of sub-issues on #3932 before this PR

👍 so this won't be the last PR before the switch.

@tpoisseau
Copy link
Contributor Author

@targos @stropitek @Sebastien-Ahkrin none of you sumbit a review so I cannot re-ask.

I adressed feedbacks from Daniel, I let you approve (or not) this PR. After this one I'll continue on next issues of #3932

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I let @stropitek review based on his comments.

Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal if not easy to resolve, but the DPI field in export seems independent from the basic / advanced mode, but it is reset when we change the mode.

CleanShot.2026-03-04.at.14.54.00.mp4

@tpoisseau
Copy link
Contributor Author

In fact, switching mode set values to default values associated to the mode. It was already like that in previous form.
If you think this needs to change, I let you create an issue.

@tpoisseau tpoisseau merged commit 7750f2e into main Mar 4, 2026
12 checks passed
@tpoisseau tpoisseau deleted the 4002-panels-display-validation-too-strict branch March 4, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panels display validation too strict

3 participants