Conversation
fix: handleAddWorkspace by parsing form values refactor: header to use withForm instead passing reset and current values props with broken types Closes: #4006
Deploying nmrium with
|
| Latest commit: |
4b7c01b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e925c3f4.nmrium.pages.dev |
| Branch Preview URL: | https://4002-panels-display-validati.nmrium.pages.dev |
|
Time for deep testing. Once everything is OK with this form, We will be able to replace original form with this one. |
|
Note that I already made a small review pass and opened a couple of sub-issues on #3932 before this PR |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
* remove "+" action in rows * autofocus on added row Refs: #4017 (comment)
👍 so this won't be the last PR before the switch. |
|
@targos @stropitek @Sebastien-Ahkrin none of you sumbit a review so I cannot re-ask. I adressed feedbacks from Daniel, I let you approve (or not) this PR. After this one I'll continue on next issues of #3932 |
targos
left a comment
There was a problem hiding this comment.
Code LGTM. I let @stropitek review based on his comments.
src/component/modal/setting/tanstack_general_settings/tabs/nuclei_tab.tsx
Outdated
Show resolved
Hide resolved
|
In fact, switching mode set values to default values associated to the mode. It was already like that in previous form. |
Uh oh!
There was an error while loading. Please reload this page.