feat(integration): show masked URL in registrations config#2794
Open
Piskoo wants to merge 3 commits intochainloop-dev:mainfrom
Open
feat(integration): show masked URL in registrations config#2794Piskoo wants to merge 3 commits intochainloop-dev:mainfrom
Piskoo wants to merge 3 commits intochainloop-dev:mainfrom
Conversation
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Webhook-based integrations (Slack, generic webhook) store the webhook URL entirely in the secrets manager, making it invisible in the UI. This caused an issue where users could not identify registrations.
This change stores a masked version of the webhook URL in the registration configuration.
Changes
Added
MaskURLto the plugin SDK. Updated Slack webhook and generic webhook plugins to store the masked URL in their registration state.Masking format
The URL host is preserved in full (identifies the service), and the path is replaced with
****plus the last 4 characters. This follows the industry-standard "last 4 visible" pattern used by Stripe (sk_test_****cDqC), OpenAI (sk-proj-****Tmr3), GitHub (ghp_****a1b2).