fix(artifact-cas): return ResourceExhausted for oversized uploads#2788
Merged
matiasinsaurralde merged 1 commit intochainloop-dev:mainfrom Feb 26, 2026
Conversation
120aab2 to
140a032
Compare
javirln
approved these changes
Feb 26, 2026
Signed-off-by: Matías Insaurralde <matias@chainloop.dev>
140a032 to
ac304d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2582
This PR improves artifact upload error semantics in
artifact-caswhen a file exceeds the configured maximum size.It introduces a typed domain error for upload size overflow in
pkg/blobmanagerand updates thebytestreamwrite path to detect that condition explicitly. Instead of masking it as a generic internal server error, the service now returns a client-visible gRPCResourceExhaustedstatus.The
bytestreamtest suite was updated to validate the new overflow classification and the expected status code for max-size rejection.Also replaced
backendwithstorageBackendinbytestream.goto avoid name shadowing (backend: blobmanager package utilities and types,storageBackend: runtime backend implementation)/Note: I've observed that we use
ResourceExhaustedto signal request retries inattestation_push.goand other places but this doesn't affectpkg/casclient/uploader.go(and artifact uploads from CLI) in particular.Before this change:
After this change:
Some points:
LogAndMaskErr)?