add information about the current bitstream in flen ('bs' and 'offset_b')#1051
Open
Ninjananas wants to merge 5 commits intocea-sec:masterfrom
Open
add information about the current bitstream in flen ('bs' and 'offset_b')#1051Ninjananas wants to merge 5 commits intocea-sec:masterfrom
Ninjananas wants to merge 5 commits intocea-sec:masterfrom
Conversation
serpilliere
reviewed
Jul 5, 2019
| if flen is not None: | ||
| l = flen(attrib, fname_values) | ||
| try: | ||
| l = flen(attrib, fname_values, bs, offset_b) |
Contributor
There was a problem hiding this comment.
With this new code, flen can raise IOError as the user can get bits from the bs.
You must have the same behavior as getbits below in case of IOError.
Contributor
Author
There was a problem hiding this comment.
I fixed it in the latest commit.
serpilliere
reviewed
Jul 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.