Skip to content

Remove ps-tree dependency which uses deprecated wmic, replace it with tree-kill #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdityaHirapara wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −170
Open

Remove ps-tree dependency which uses deprecated wmic, replace it with tree-kill #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions lib/Local.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var childProcess = require('child_process'),
LocalBinary = require('./LocalBinary'),
LocalError = require('./LocalError'),
version = require('../package.json').version,
psTree = require('ps-tree');
treeKill = require('tree-kill');

function Local(){
this.sanitizePath = function(rawPath) {
Expand Down Expand Up @@ -342,32 +342,7 @@ function Local(){
};

this.killAllProcesses = function(callback){
psTree(this.pid, (err, children) => {
var childPids = children.map(val => val.PID);
var killChecker = setInterval(() => {
if(childPids.length === 0) {
clearInterval(killChecker);
try {
process.kill(this.pid);
// This gives time to local binary to send kill signal to railsApp.
setTimeout(() => {
this.isProcessRunning = false;
callback();
}, 2000);
} catch(err) {
this.isProcessRunning = false;
callback();
}
}
for(var i in childPids) {
try {
process.kill(childPids[i]);
} catch(err) {
childPids.splice(i, 1);
}
}
},500);
});
treeKill(this.pid, 'SIGTERM', callback);
};
}

Expand Down
156 changes: 14 additions & 142 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"agent-base": "^6.0.2",
"https-proxy-agent": "^5.0.1",
"is-running": "^2.1.0",
"ps-tree": "=1.2.0"
"tree-kill": "^1.2.2"
},
"devDependencies": {
"eslint": "^7.0.0",
Expand Down