perf: switch to empathic find package traversal#1053
perf: switch to empathic find package traversal#105343081j wants to merge 1 commit intobabel:mainfrom
empathic find package traversal#1053Conversation
Uses `empathic/find` for finding the closest `package.json`, a much faster and smaller library than the various over-specialised alternatives lying around.
|
Thank you.
|
|
Over time, the de-dupe will switch since we're in the process of moving many other popular tools to do this switch too. you're right that the performance bump won't be much here since it isn't called often, but it is greater than none. there's currently no reason to not do this switch other than doubt that the de-dupe will be improving, but we have to start somewhere. what you should be aware of is that empathic replaces many other packages in other repos (there are many different npm packages doing roughly the same thing). eventually, we will be installing this one package instead of many, across a given installation. babel-loader is just one part of it |
|
The new |
Uses
empathic/findfor finding the closestpackage.json, a much faster and smaller library than the various over-specialised alternatives lying around.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
We traverse the file system for the closest package.json-containing directory.
What is the new behavior?
N/A
Does this PR introduce a breaking change?