fix: remove usage of go-chi v1 and upgrade v5 to 5.2.5#169
Open
WilliamCollishaw wants to merge 2 commits intoaws:developfrom
Open
fix: remove usage of go-chi v1 and upgrade v5 to 5.2.5#169WilliamCollishaw wants to merge 2 commits intoaws:developfrom
WilliamCollishaw wants to merge 2 commits intoaws:developfrom
Conversation
WilliamCollishaw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Replaces usage of deprecated go-chi v1 with v5 and upgrades v5 from 5.2.2 to 5.2.5, patching GHSA-mqqf-5wvp-8fh8.
When running
go get ./...the following is logged:go: module github.com/go-chi/chi is deprecated: Please upgrade to the latest major version: go get github.com/go-chi/chi/v5The usage of go-chi v1 was removed in #149 for security reasons and was re-introduced in #157 resulting in both versions being used.
Both versions are flagging findings in AWS Inspector
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.