Fix validation for DataFrame with only time column in dataframe_to_tsfile#736
Merged
jt2594838 merged 7 commits intoapache:developfrom Mar 4, 2026
Merged
Conversation
jt2594838
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix validation for DataFrame with only time column in
dataframe_to_tsfileProblem: The check
len(column_schemas) == 0never triggers when the DataFrame has only a time column, because in that casecolumn_schemasstill contains one element (the time column). The intended guard was to reject "no data columns besides time."Change: Require at least one data column (FIELD or TAG) by filtering out TIME columns and checking that the remaining list is non-empty before building the table schema.
Tests: Existing
test_dataframe_to_tsfile_no_data_columnsnow correctly raisesValueError; addedtest_dataframe_to_tsfile_only_time_column_raisesto explicitly cover the only-time-column case.