[SPARK-55636][CONNECT] Add detailed errors in case of deduplication of invalid columns#54422
Open
pranavdev022 wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-55636][CONNECT] Add detailed errors in case of deduplication of invalid columns#54422pranavdev022 wants to merge 2 commits intoapache:masterfrom
pranavdev022 wants to merge 2 commits intoapache:masterfrom
Conversation
khakhlyuk
approved these changes
Feb 23, 2026
Contributor
khakhlyuk
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
khakhlyuk
reviewed
Feb 23, 2026
| else Deduplicate(allColumns, queryExecution.analyzed) | ||
| } else { | ||
| val toGroupColumnNames = rel.getColumnNamesList.asScala.toSeq | ||
| val fieldNames = allColumns.map(_.name).mkString(", ") |
Contributor
There was a problem hiding this comment.
nitty nit: this line can be moved between 1448 and 1449 since it's not used in the outer scope
Contributor
Author
There was a problem hiding this comment.
yes moved, that would be better.
Contributor
|
Thanks for working on error messages/debugging/dev ex :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the error handling for invalid deduplicate column names in Spark Connect to use the standard
UNRESOLVED_COLUMN_AMONG_FIELD_NAMESerror class instead of throwing INTERNAL_ERROR, a generic error message.Why are the changes needed?
The previous error message in Spark Connect was not consistent with classic Spark and lacked helpful context.
This change aligns Spark Connect error messages with classic Spark, providing users with:
UNRESOLVED_COLUMN_AMONG_FIELD_NAMESinstead ofINTERNAL_ERROR).Does this PR introduce any user-facing change?
Yes. Error messages for invalid deduplicate column names in Spark Connect are now more detailed and consistent with classic Spark.
How was this patch tested?
Tested with a custom image with the proposed changes.
Was this patch authored or co-authored using generative AI tooling?
No