Migrate RenameCoreAPI from homegrown @EndPoint/@Command to JAX-RS; use SolrJettyTestRule in tests#4172
Open
epugh wants to merge 4 commits intoapache:mainfrom
Open
Migrate RenameCoreAPI from homegrown @EndPoint/@Command to JAX-RS; use SolrJettyTestRule in tests#4172epugh wants to merge 4 commits intoapache:mainfrom
epugh wants to merge 4 commits intoapache:mainfrom
Conversation
…ate tests Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Contributor
Author
|
I've done a bit of work in my own |
dsmiley
reviewed
Feb 28, 2026
| solrTestRule.startSolr(createTempDir()); | ||
| solrTestRule.newCollection(DEFAULT_TEST_CORENAME).withConfigSet(ExternalPaths.DEFAULT_CONFIGSET).create(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
code above seems fine... but the setup and tests below are low-level, reaching directly into Solr instead of using SolrClient. Why?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RenameCoreAPI.javawas the last remnant of the old@EndPoint/@CommandV2 API style for core renaming. The JAX-RS implementation (RenameCore.java,RenameCoreApi.java,RenameCoreRequestBody.java) already existed and was fully wired intoCoreAdminHandler.getJerseyResources()andCoreAdminOperation.RENAME_OP— the old class was dead production code only referenced in a mock-based test.Changes
RenameCoreAPI.java— superseded byRenameCore.javaV2CoreAPIMappingTest— removedRenameCoreAPIregistration and its mock-basedtestRenameCoreAllParamstestRenameCoreAPITest— unit tests forRenameCoreusingSolrJettyTestRule(no mocks, noinitCore), following the pattern ofShowFileRequestHandlerTestTests cover: same-name early return, missing request body, and missing
toparameter.